refactor: reorder function sequence to make it more reasonable #1296
+706
−666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Sun <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
=========================================
- Coverage 15.4% 15.31% -0.1%
=========================================
Files 174 176 +2
Lines 11026 11014 -12
=========================================
- Hits 1699 1687 -12
Misses 9208 9208
Partials 119 119
|
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun [email protected]
Ⅰ. Describe what this PR did
This pr tries to make container, image, network, volume interface's implementation much more in order. This will make go files much more readable.
In addition, I split two files
exec_bridge.goandcontainer_exec.gosince they are quite decoupled, I think.Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none